Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v1.8] Change order of ensureCABundleConfigMap task #3247

Merged
merged 1 commit into from
Jun 19, 2024
Merged

[release/v1.8] Change order of ensureCABundleConfigMap task #3247

merged 1 commit into from
Jun 19, 2024

Conversation

kubermatic-bot
Copy link
Contributor

This is an automated cherry-pick of #3245

/assign xmudrii

Load the CA bundle before any addon installations to resolve issues with untrusted  TLS connections in environments with self-signed certifications.

@kubermatic-bot kubermatic-bot mentioned this pull request Jun 19, 2024
Merged
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.8 milestone Jun 19, 2024
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 19, 2024
@kubermatic-bot kubermatic-bot force-pushed the cherry-pick-3245-to-release/v1.8 branch from c788ff1 to 9400360 Compare June 19, 2024 13:08
xmudrii
xmudrii approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/kind bug
/lgtm
/approve

@kubermatic-bot kubermatic-bot added lgtm Indicates that a PR is ready to be merged. kind/bug Categorizes issue or PR as related to a bug. labels Jun 19, 2024
@kubermatic-bot
Copy link
Contributor Author

LGTM label has been added.

Git tree hash: cc0f4b3d0453b29bd5a1afce2f04ba7c8b1342e8

@kubermatic-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jun 19, 2024
@xmudrii xmudrii added the cherry-pick-approved Indicates a PR has been approved by release managers. label Jun 19, 2024
@kubermatic-bot kubermatic-bot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jun 19, 2024
@xmudrii
Copy link
Member

xmudrii commented Jun 19, 2024

/retest

1 similar comment
@xmudrii
Copy link
Member

xmudrii commented Jun 19, 2024

/retest

@kubermatic-bot kubermatic-bot merged commit 2dcafb3 into kubermatic:release/v1.8 Jun 19, 2024
14 checks passed
@kubermatic-bot kubermatic-bot deleted the cherry-pick-3245-to-release/v1.8 branch June 19, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a PR has been approved by release managers. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.8
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kubermatic-bot @xmudrii @mohamed-rafraf