Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/v1.8] Fix snapshot-webhook admitting non-supported objects and add default VolumeSnapshotClass for all supported providers #3275

Conversation

kubermatic-bot
Copy link
Contributor

This is an automated cherry-pick of #3273

/assign xmudrii

- Add default VolumeSnapshotClass for all supported providers as part of the `default-storage-class` addon
- Fix snapshot-webhook admitting non-supported objects (`VolumeSnapshots` and `VolumeSnapshotContents`). This fixes an issue that caused inability to create new `VolumeSnapshots`

Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.8 milestone Jun 26, 2024
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 26, 2024
@kron4eg
Copy link
Member

kron4eg commented Jun 26, 2024

/approve
/lgtm
/kind bug

@kubermatic-bot kubermatic-bot added kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. labels Jun 26, 2024
@kubermatic-bot
Copy link
Contributor Author

LGTM label has been added.

Git tree hash: f238f4a528154016fdb24f28bb3cfa0e5d17fa4a

@kubermatic-bot kubermatic-bot removed the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Jun 26, 2024
@kubermatic-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2024
@kron4eg
Copy link
Member

kron4eg commented Jun 26, 2024

cc @kubermatic/sig-release-managers

@kron4eg kron4eg added cherry-pick-approved Indicates a PR has been approved by release managers. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Jun 26, 2024
@kron4eg
Copy link
Member

kron4eg commented Jun 26, 2024

/retest

@kubermatic-bot kubermatic-bot merged commit d5c14f9 into kubermatic:release/v1.8 Jun 26, 2024
14 checks passed
@kubermatic-bot kubermatic-bot deleted the cherry-pick-3273-to-release/v1.8 branch June 26, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a PR has been approved by release managers. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants