Fix metrics-server for all providers #424
Conversation
Signed-off-by: Artiom Diomin <kron82@gmail.com>
kubermatic-bot
added
release-note
|
/cherrypick release/v0.6 |
|
@kron4eg: once the present PR merges, I will cherry-pick it on top of release/v0.6 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -208,6 +208,7 @@ func metricsServerDeployment() *appsv1.Deployment { | |||
| ImagePullPolicy: corev1.PullIfNotPresent, | |||
| Args: []string{ | |||
| "--kubelet-insecure-tls", | |||
| "--kubelet-preferred-address-types=InternalIP,InternalDNS,ExternalDNS,ExternalIP", | |||
There was a problem hiding this comment.
metrics-server will use first accessible address type.
on hetzner it will be ExternalIP, others do support InternalIP. With provider none real external IP will be indicated as InternalIP so will work ether way.
|
LGTM label has been added. Git tree hash: 5b061385ee42fd604fbd59bce709320fe9fc8890
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
|
/retest |
|
/retest pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.1 |
|
/retest |
|
@kron4eg: new pull request created: #427 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes #423