-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use kind for E2E tests #1304
Use kind for E2E tests #1304
Conversation
Skipping CI for Draft Pull Request. |
/test pull-machine-controller-e2e-aws |
/test pull-machine-controller-e2e-aws |
2 similar comments
/test pull-machine-controller-e2e-aws |
/test pull-machine-controller-e2e-aws |
/test pull-machine-controller-e2e-aws |
2 similar comments
/test pull-machine-controller-e2e-aws |
/test pull-machine-controller-e2e-aws |
/hold |
I opted for flannel because I have switched to |
/retest |
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
Reverted back to flannel. Maybe we can see switching back to |
Can we see the logs or failed pods somewhere, so we have more than "didn't work" for the future in case this gets important for kind 0.13+ ? Presumably, https://public-prow.loodse.com/view/gs/prow-dev-public-data/pr-logs/pull/kubermatic_machine-controller/1304/pull-machine-controller-e2e-aws-arm/1531939052419289088 is one of the jobs that failed due to CNI? |
TBH, I'm not sure do we want to block on this, but |
Yes, how about we open a new issue for that and investigate? :) I'd really like for this PR to be merged and we can always update/improve/refactor the CNI stuff later, against a separate issue. |
Can you provide logs that explain why
failed? |
I'm focused on some other ticket for now. So I don't have the bandwidth to do that. If you want, I can revert my change and you can check the logs accordingly. |
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@xrstf reverted and switched back to kindnet. You can debug and go through the logs now. |
|
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
/retest |
@ahmedwaleedmalik It's mostly like that kindnet doesn't work with non-kind nodes. I guess this is sort of expected because kindnet is supposed to be a very basic CNI implementation. In this case, I think resorting to Flannel is a good decision. |
/retest |
/retest @xmudrii then it's good to go from my side. This azure testing is just flaking out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is amazing PR, I'm very happy that we finally use Kind instead of Hetzner. ⚡ ⚡ ⚡
Here are some approves for this amazing PR:
/approve
/approve
/approve
LGTM label has been added. Git tree hash: 3dd3c405cb23b56e83529a302bbcaf8488132f9a
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmedwaleedmalik, xmudrii, xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
Signed-off-by: Waleed Malik ahmedwaleedmalik@gmail.com
What this PR does / why we need it:
![Alt Text](https://camo.githubusercontent.com/7f2daa5e6138aebaf5fdb45a800fba34e40f1ec3bd2eb92e8da28cf726b324c2/68747470733a2f2f6d656469612e67697068792e636f6d2f6d656469612f4d65507037384359624f61596833694e425a2f67697068792d646f776e73697a65642d6c617267652e676966)
Which issue(s) this PR fixes (optional, in
fixes #<issue number>
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Optional Release Note: