Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable OperatingSystemManager in E2E tests #1369

Merged
merged 2 commits into from
Jul 27, 2022
Merged

Enable OperatingSystemManager in E2E tests #1369

merged 2 commits into from
Jul 27, 2022

Conversation

ahmedwaleedmalik
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik commented Jul 21, 2022 •
edited

What this PR does / why we need it:
Enable OperatingSystemManager in E2E tests.

Which issue(s) this PR fixes (optional, in fixes #<issue number> format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Optional Release Note:

* Operating System Manager is enabled by default and it's responsible for creating and managing the required configurations for worker nodes. 
* [ACTION REQUIRED] Existing worker machines will not be migrated to use OSM automatically. Users need to update the `MachineDeployments` manually or simply delete the machines to ensure that the machines are consuming configurations created by OSM.

@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Jul 21, 2022
@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 21, 2022
@ahmedwaleedmalik
Copy link
Member Author

/test pull-machine-controller-e2e-vmware-cloud-director

@kubermatic-bot kubermatic-bot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. sig/osm Denotes a PR or issue as being assigned to SIG OSM. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jul 21, 2022
@ahmedwaleedmalik
Copy link
Member Author

/test pull-machine-controller-e2e-vmware-cloud-director

Credentials were stale

@ahmedwaleedmalik ahmedwaleedmalik marked this pull request as draft July 22, 2022 16:05
@kubermatic-bot kubermatic-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 22, 2022
@ahmedwaleedmalik
Copy link
Member Author

/test all
/test pull-machine-controller-e2e-vmware-cloud-director
/test pull-machine-controller-e2e-alibaba
/test pull-machine-controller-e2e-equinix-metal

@ahmedwaleedmalik
Copy link
Member Author

/test pull-machine-controller-e2e-openstack

2 similar comments
@ahmedwaleedmalik
Copy link
Member Author

/test pull-machine-controller-e2e-openstack

@ahmedwaleedmalik
Copy link
Member Author

/test pull-machine-controller-e2e-openstack

@ahmedwaleedmalik
Copy link
Member Author

/hold
We need a new release for OSM to move forward with this PR.

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 23, 2022
@ahmedwaleedmalik ahmedwaleedmalik marked this pull request as ready for review July 23, 2022 19:52
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 23, 2022
@ahmedwaleedmalik
Copy link
Member Author

/test pull-machine-controller-e2e-vmware-cloud-director
/test pull-machine-controller-e2e-alibaba
/test pull-machine-controller-e2e-equinix-metal

@ahmedwaleedmalik ahmedwaleedmalik marked this pull request as draft July 23, 2022 21:10
@kubermatic-bot kubermatic-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 23, 2022
@ahmedwaleedmalik
Copy link
Member Author

/test all
/test pull-machine-controller-e2e-vmware-cloud-director
/test pull-machine-controller-e2e-alibaba
/test pull-machine-controller-e2e-equinix-metal
/test pull-machine-controller-e2e-azure-redhat-satellite

😵‍💫

@ahmedwaleedmalik
Enable OSM in E2E tests
1fe357b 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik
Copy link
Member Author

/test all
/test pull-machine-controller-e2e-vmware-cloud-director
/test pull-machine-controller-e2e-alibaba
/test pull-machine-controller-e2e-equinix-metal
/test pull-machine-controller-e2e-azure-redhat-satellite

moadqassem
moadqassem approved these changes Jul 26, 2022
View reviewed changes
Copy link
Member

@moadqassem moadqassem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!
/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 524f1b57667e38191bf7e6b5e5fda9514728c80f

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, moadqassem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahmedwaleedmalik
Update OSM image
09f2fb5 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2022
@ahmedwaleedmalik ahmedwaleedmalik marked this pull request as ready for review July 27, 2022 10:23
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 27, 2022
@ahmedwaleedmalik
Copy link
Member Author

/test all
/test pull-machine-controller-e2e-vmware-cloud-director
/test pull-machine-controller-e2e-alibaba
/test pull-machine-controller-e2e-equinix-metal
/test pull-machine-controller-e2e-azure-redhat-satellite

@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Jul 27, 2022 •
edited

@ahmedwaleedmalik: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-machine-controller-e2e-anexia e786730 link true /test pull-machine-controller-e2e-anexia

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ahmedwaleedmalik
Copy link
Member Author

/retest

vSphere failed due to webhook timeouts. Hetzner falked.

@xrstf
Copy link
Contributor

xrstf commented Jul 27, 2022

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 69fefa2a2c272c08c339da234bbdd0c1138e369c

@ahmedwaleedmalik
Copy link
Member Author

/unhold

🎏

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 27, 2022
@kubermatic-bot kubermatic-bot merged commit 6232612 into kubermatic:master Jul 27, 2022
@ahmedwaleedmalik ahmedwaleedmalik deleted the e2e-enable-osm branch July 27, 2022 13:10
@ahmedwaleedmalik ahmedwaleedmalik mentioned this pull request Aug 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moadqassem moadqassem Awaiting requested review from moadqassem

Assignees

@xrstf xrstf

@moadqassem moadqassem

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. sig/osm Denotes a PR or issue as being assigned to SIG OSM. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ahmedwaleedmalik @kubermatic-bot @xrstf @moadqassem