-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Calico as CNI for e2e and disable node readiness checks #1459
Conversation
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
This reverts commit 35ad25c.
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
Skipping CI for Draft Pull Request. |
/test pull-machine-controller-e2e-vsphere |
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
/test pull-machine-controller-e2e-vsphere |
This reverts commit 72b0d18.
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@embik: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: 2cac2634fe77bc81b9c71fe8ee4918fd40fd47ae
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: embik, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ic#1459) * Update containerized check Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Test if kindnet CNI works Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Revert "Test if kindnet CNI works" This reverts commit 35ad25c. * Replace Flannel with Cilium Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Set operator.replicas=1 for cilium Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Remove CentOS 7 tests Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Add Calico as CNI Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Do not check node readiness, just verify node exists Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Revert "Remove CentOS 7 tests" This reverts commit 72b0d18. * Add a test for node conditions except NodeReady Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Fix yamllint issues Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Fix linting issue Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Disable upgrade Prow job Signed-off-by: Marvin Beckers <marvin@kubermatic.com> Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
…d use KKP `main` branch (#1465) * Use Calico as CNI for e2e and disable node readiness checks (#1459) * Update containerized check Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Test if kindnet CNI works Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Revert "Test if kindnet CNI works" This reverts commit 35ad25c. * Replace Flannel with Cilium Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Set operator.replicas=1 for cilium Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Remove CentOS 7 tests Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Add Calico as CNI Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Do not check node readiness, just verify node exists Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Revert "Remove CentOS 7 tests" This reverts commit 72b0d18. * Add a test for node conditions except NodeReady Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Fix yamllint issues Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Fix linting issue Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Disable upgrade Prow job Signed-off-by: Marvin Beckers <marvin@kubermatic.com> Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Use 'main' as KKP branch instead of 'master' (#1464) Signed-off-by: Marvin Beckers <marvin@kubermatic.com> Signed-off-by: Marvin Beckers <marvin@kubermatic.com> Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
…ic#1459) * Update containerized check Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Test if kindnet CNI works Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Revert "Test if kindnet CNI works" This reverts commit 35ad25c. * Replace Flannel with Cilium Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Set operator.replicas=1 for cilium Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Remove CentOS 7 tests Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Add Calico as CNI Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Do not check node readiness, just verify node exists Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Revert "Remove CentOS 7 tests" This reverts commit 72b0d18. * Add a test for node conditions except NodeReady Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Fix yamllint issues Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Fix linting issue Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Disable upgrade Prow job Signed-off-by: Marvin Beckers <marvin@kubermatic.com> Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
…ic#1459) * Update containerized check Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Test if kindnet CNI works Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Revert "Test if kindnet CNI works" This reverts commit 35ad25c. * Replace Flannel with Cilium Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Set operator.replicas=1 for cilium Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Remove CentOS 7 tests Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Add Calico as CNI Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Do not check node readiness, just verify node exists Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Revert "Remove CentOS 7 tests" This reverts commit 72b0d18. * Add a test for node conditions except NodeReady Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Fix yamllint issues Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Fix linting issue Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Disable upgrade Prow job Signed-off-by: Marvin Beckers <marvin@kubermatic.com> Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
What this PR does / why we need it:
This is a bit complicated to explain but essentially the e2e tests running out of kind were only somewhat working, but flannel "covered" that up a bit. The problem is between the kind control plane and the joining nodes; CNI pods cannot talk to the Kubernetes API endpoint as the
Endpoints
for the "kubernetes"Service
is an internal IP nodes will not be able to reach. This also affectskube-proxy
never being able to properly start.For some reason, flannel still marked the nodes as
Ready
(although technically they weren't), same for Cilium, but none really worked for CNI and flannel broke during the CI cluster upgrade (machine-controller-webhook was no longer able to resolve DNS due to service IPs no longer properly routing).This PR moves to Calico to bring back the kind control plane, but removes the readiness check for a node (since no node can ever really be initialised by CNI in our test setup) and resorts to just making sure a Node object exists for a machine. A follow-up issue was raised at #1462.
Which issue(s) this PR fixes:
Fixes #
What type of PR is this?
/kind cleanup
/kind regression
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: