Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anexia Provider: allow configuration of multiple disks #1665

Merged

Conversation

marioreggiori
Copy link
Contributor

What this PR does / why we need it:
This PR enables configuration of multiple disks for the Anexia provider.

What type of PR is this?
/kind feature

Special notes for your reviewer:
Backporting to 1.54 and 1.56 caused merge conflicts locally. So I'll create two additional PRs as soon as this is accepted.

Does this PR introduce a user-facing change? Then add your Release Note here:

Anexia Provider: allow configuration of multiple disks

Documentation:

examples/anexia-machinedeployment.yaml

Signed-off-by: Mario Schäfer <mschaefer@anexia-it.com>
@kubermatic-bot kubermatic-bot added docs/provided Denotes a PR that has a valid documentation reference. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 16, 2023
@kubermatic-bot
Copy link
Contributor

Hi @marioreggiori. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 16, 2023
@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Jun 16, 2023
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/hold since we are in the middle of a code freeze I'm not sure if we can move ahead with this change before the new release. But I'll leave that decision up to the @kubermatic/sig-release-managers.

@kubermatic-bot kubermatic-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Jun 16, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 53b2318220c1df7709bab5dde74b85d741ca9955

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, marioreggiori

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2023
@ahmedwaleedmalik
Copy link
Member

/retest

@embik
Copy link
Member

embik commented Jun 19, 2023

Hey @marioreggiori, we are going to cut the next machine-controller release very soon and after branching off our release branch, we'll be able to pick this PR up to go into main.

@ahmedwaleedmalik
Copy link
Member

/unhold

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 20, 2023
@kubermatic-bot kubermatic-bot merged commit 94e2005 into kubermatic:main Jun 20, 2023
@ahmedwaleedmalik
Copy link
Member

/cherrypick release/v1.57

@kubermatic-bot
Copy link
Contributor

@ahmedwaleedmalik: new pull request created: #1669

In response to this:

/cherrypick release/v1.57

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/provided Denotes a PR that has a valid documentation reference. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants