-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anexia Provider: allow configuration of multiple disks #1665
Anexia Provider: allow configuration of multiple disks #1665
Conversation
Signed-off-by: Mario Schäfer <mschaefer@anexia-it.com>
Hi @marioreggiori. Thanks for your PR. I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/hold since we are in the middle of a code freeze I'm not sure if we can move ahead with this change before the new release. But I'll leave that decision up to the @kubermatic/sig-release-managers.
LGTM label has been added. Git tree hash: 53b2318220c1df7709bab5dde74b85d741ca9955
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmedwaleedmalik, marioreggiori The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Hey @marioreggiori, we are going to cut the next machine-controller release very soon and after branching off our release branch, we'll be able to pick this PR up to go into |
/unhold |
/cherrypick release/v1.57 |
@ahmedwaleedmalik: new pull request created: #1669 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
This PR enables configuration of multiple disks for the Anexia provider.
What type of PR is this?
/kind feature
Special notes for your reviewer:
Backporting to 1.54 and 1.56 caused merge conflicts locally. So I'll create two additional PRs as soon as this is accepted.
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: