Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for kubernetes v1.25 #1709

Merged
merged 3 commits into from
Oct 5, 2023
Merged

Remove support for kubernetes v1.25 #1709

merged 3 commits into from
Oct 5, 2023

Conversation

ahmedwaleedmalik
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik commented Oct 4, 2023 •
edited

What this PR does / why we need it:
Kubernetes v1.25 will be EOL on 27 Oct 2023

https://kubernetes.io/releases/#release-v1-25

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?

/kind cleanup

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Remove support for Kubernetes v1.25

Documentation:

NONE

@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Oct 4, 2023
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/chore Updating grunt tasks etc; no production code changes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 4, 2023
@ahmedwaleedmalik
Copy link
Member Author

[2023-10-04T12:07:07+00:00] This script was unable to determine the external IP for kube-apiserver.

So the usual, transient error, retry should fix this.

/retest

@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). and removed do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. labels Oct 4, 2023
@ahmedwaleedmalik
Copy link
Member Author

/retest

@kron4eg
Copy link
Member

kron4eg commented Oct 4, 2023

Kubernetes v1.25 will be EOL on 27 Oct 2023

Isn't it a bit too early yet?

@ahmedwaleedmalik
Copy link
Member Author

Kubernetes v1.25 will be EOL on 27 Oct 2023

Isn't it a bit too early yet?

I think this is the right time to do this since we are now close to KKP 2.24 as well which should drop the support for 1.25. cc @xrstf

@ahmedwaleedmalik
Copy link
Member Author

/retest

@ahmedwaleedmalik ahmedwaleedmalik mentioned this pull request Oct 4, 2023
Open
@ahmedwaleedmalik
Remove support for kubernetes v1.25
374759b 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@kubermatic-bot kubermatic-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 5, 2023
@ahmedwaleedmalik ahmedwaleedmalik added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed kind/chore Updating grunt tasks etc; no production code changes. labels Oct 5, 2023
@ahmedwaleedmalik
Fix issue with port not being allocated in time
2e0d208 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik
Copy link
Member Author

/retest

Seem like genuine failures. Although this is completely unrelated to this PR. If they fail again I'll open a GH issue for that.

This was referenced Oct 5, 2023
Merged
Closed
@ahmedwaleedmalik
Copy link
Member Author

ahmedwaleedmalik commented Oct 5, 2023 •
edited

@xrstf we need to override

  • pull-machine-controller-e2e-hetzner

Here is the GH ticket to track/fix the failures #1710

@ahmedwaleedmalik
Fix AWS EBS tests
6ff93a3 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@kron4eg
Copy link
Member

kron4eg commented Oct 5, 2023

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f227929acdc0e2543d3e0f161c1a6b84d5e8340c

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2023
@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Oct 5, 2023 •
edited

@ahmedwaleedmalik: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-machine-controller-e2e-openstack-project-auth 5d9b531 link true /test pull-machine-controller-e2e-openstack-project-auth
pull-machine-controller-e2e-ubuntu-upgrade 5d9b531 link true /test pull-machine-controller-e2e-ubuntu-upgrade

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@xrstf
Copy link
Contributor

xrstf commented Oct 5, 2023

/override pull-machine-controller-e2e-hetzner

@kubermatic-bot
Copy link
Contributor

@xrstf: Overrode contexts on behalf of xrstf: pull-machine-controller-e2e-hetzner

In response to this:

/override pull-machine-controller-e2e-hetzner

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot merged commit da744cd into kubermatic:main Oct 5, 2023
25 checks passed
@embik embik mentioned this pull request Oct 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrstf xrstf Awaiting requested review from xrstf

@kron4eg kron4eg Awaiting requested review from kron4eg

Assignees

@kron4eg kron4eg

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ahmedwaleedmalik @kron4eg @kubermatic-bot @kubermatic-triage-bot @xrstf