Configure provider-id for the machines/nodes #1723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MC will inject provider-id for the machines that are created against cloud providers that don't have in-tree or external CCM support Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
kubermatic-bot
added
release-note
|
Skipping CI for Draft Pull Request. |
kubermatic-bot
added
dco-signoff: yes
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
kubermatic-bot
added
docs/none
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
kubermatic-bot
added
size/L
ahmedwaleedmalik
changed the title
kubermatic-bot
removed
the
do-not-merge/work-in-progress
|
LGTM label has been added. Git tree hash: 795d405699d3d5fcb3d662195556b4c2c4475c5c
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cnvergence, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
|
/test pull-machine-controller-e2e-hetzner pull-machine-controller-e2e-kubevirt |
|
|
|
/test pull-machine-controller-e2e-kubevirt |
|
/retest Review the full test history Silence the bot with an |
|
/retest |
|
/cherry-pick release/v1.57 |
|
@ahmedwaleedmalik: #1723 failed to apply on top of branch "release/v1.57": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Will do a manual backport |
ahmedwaleedmalik
added a commit
to ahmedwaleedmalik/machine-controller
that referenced
this pull request
Mar 4, 2024
* Configure provider-id for the machines/nodes MC will inject provider-id for the machines that are created against cloud providers that don't have in-tree or external CCM support Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com> * Add exception in golangci-lint Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com> * Refactored code Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com> --------- Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
kubermatic-bot
pushed a commit
that referenced
this pull request
Mar 4, 2024
* Configure provider-id for the machines/nodes MC will inject provider-id for the machines that are created against cloud providers that don't have in-tree or external CCM support * Add exception in golangci-lint * Refactored code --------- Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
machine-controller will inject provider-id for the machines that are created against cloud providers that don't have in-tree or external CCM support. The generated providerID will be configured on the machine and node respectively.
Which issue(s) this PR fixes:
Fixes #1552
What type of PR is this?
/kind feature
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: