Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use c1.small.x86 instance type on Packet #812

Merged
merged 1 commit into from
Aug 31, 2020
Merged

Use c1.small.x86 instance type on Packet #812

merged 1 commit into from
Aug 31, 2020

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Aug 22, 2020 •
edited
Loading

What this PR does / why we need it:

We've used t1.small.x86 instances for running E2E tests because we
don't need large instances. The t1.small.x86 instance type is first
generation, and as the first generation is deprecated, it's not
available anymore. The c1.small.x86 instances are bit more expensive,
but it's the smallest instance type currently available. Besides that,
we now run Packet E2E tests in the Amsterdam region.

Optional Release Note:

NONE

@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 22, 2020
@xmudrii
Copy link
Member Author

xmudrii commented Aug 22, 2020

/test pull-machine-controller-e2e-packet

@xmudrii
Copy link
Member Author

xmudrii commented Aug 22, 2020

/hold
until we are not sure that this works

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 22, 2020
@dongsupark
Copy link
Contributor

FYI, recently Packet's t1.small.x86 became deprecated, and Packet simply does not allow new projects to access to t1.small.x86.
The type might be still accessible in existing projects in the facility ams1, but it could disappear soon.
That's why projects like Lokomotive changed the default type to c3.small.x86.

@xmudrii
Copy link
Member Author

xmudrii commented Aug 28, 2020

/test pull-machine-controller-e2e-packet

@xmudrii
Use c1.small.x86 instance type on Packet
f381903 
We've used t1.small.x86 instances for running E2E tests because we
don't need large instances. The t1.small.x86 instance type is first
generation, and as the first generation is deprecated, it's not
available anymore. The c1.small.x86 instances are bit more expensive,
but it's the smallest instance type currently available. Besides that,
we now run Packet E2E tests in the Amsterdam region.
@xmudrii xmudrii changed the title Run Packet E2E tests in Amsterdam region Use c1.small.x86 instance type on Packet Aug 28, 2020
@xmudrii
Copy link
Member Author

xmudrii commented Aug 28, 2020

/test pull-machine-controller-e2e-packet

@xmudrii
Copy link
Member Author

xmudrii commented Aug 31, 2020

/retest

@xmudrii
Copy link
Member Author

xmudrii commented Aug 31, 2020

/test pull-machine-controller-e2e-packet

4 similar comments
@xmudrii
Copy link
Member Author

xmudrii commented Aug 31, 2020

/test pull-machine-controller-e2e-packet

@xmudrii
Copy link
Member Author

xmudrii commented Aug 31, 2020

/test pull-machine-controller-e2e-packet

@xmudrii
Copy link
Member Author

xmudrii commented Aug 31, 2020

/test pull-machine-controller-e2e-packet

@xmudrii
Copy link
Member Author

xmudrii commented Aug 31, 2020

/test pull-machine-controller-e2e-packet

xrstf
xrstf approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@xrstf xrstf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f74833e7d3f9332aa892db01df113f870bf792f2

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xmudrii
Copy link
Member Author

xmudrii commented Aug 31, 2020

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 31, 2020
@kubermatic-bot kubermatic-bot merged commit 3a1878b into kubermatic:master Aug 31, 2020
@xmudrii xmudrii deleted the packet-e2e-ams1 branch August 31, 2020 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrstf xrstf xrstf approved these changes

Assignees

@xrstf xrstf

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xmudrii @dongsupark @kubermatic-bot @xrstf