Domain name is not required when using application credentials #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
kubermatic-bot
added
release-note-none
|
LGTM label has been added. Git tree hash: 0246b92d37f3976f60c9a9a4703243900ff02686
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmedwaleedmalik, moadqassem The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
pushed a commit
that referenced
this pull request
Apr 1, 2022
* Add more linters Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com> * Upgrade golangci-lint to v1.44.0 in prow jobs Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com> * Fix template comment spacing in default OSPs Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com> * Refactor webhooks for OSM Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com> Unmarshal provider configs in strict mode * Domain name is not required when using application credentials (#154) Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com> * Disable firewalld on supported OSes (#155) * Disable firewalld on supported OSes Signed-off-by: Artiom Diomin <kron82@gmail.com> * Further firewalld cleanup in RHEL OSP Signed-off-by: Artiom Diomin <kron82@gmail.com> Update testdata Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com> Additional RBAC for webhooks Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com> Refactored code Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com> Refactored code Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com> * Refactored code Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com> Co-authored-by: Artiom Diomin <kron82@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Waleed Malik ahmedwaleedmalik@gmail.com
What this PR does / why we need it:
Domain name is not required when using application credentials.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
xref kubermatic/kubeone#1872