Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v0.4] Support yum repos cloud-init module #183

Merged
merged 3 commits into from
Jul 7, 2022
Merged

[release/v0.4] Support yum repos cloud-init module #183

merged 3 commits into from
Jul 7, 2022

Conversation

ahmedwaleedmalik
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

* initialize the node-containerd-registry-mirrors flag 
* Support yum repos cloud-init module

@moadqassem @ahmedwaleedmalik
initialize the node-containerd-registry-mirrors flag (#171)
f337058 
Signed-off-by: Moath Qasim <moad.qassem@gmail.com>

Signed-off-by: Moath Qasim <moad.qassem@gmail.com>
@moadqassem @ahmedwaleedmalik
Support yum repos cloud-init module (#177)
b15aa94 
* support yum repos cloud-init module

Signed-off-by: Moath Qasim <moad.qassem@gmail.com>

* adding tests for yum repos module

Signed-off-by: Moath Qasim <moad.qassem@gmail.com>
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Jul 7, 2022
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 7, 2022
@ahmedwaleedmalik
Update testdata for unit tests
db33f2b 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik ahmedwaleedmalik merged commit 399d80f into release/v0.4 Jul 7, 2022
@kubermatic-bot kubermatic-bot deleted the release-v0.4-backports branch July 7, 2022 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahmedwaleedmalik @kubermatic-bot @moadqassem