Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for docker as container runtime #250

Merged

Conversation

ahmedwaleedmalik
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik commented Jan 5, 2023

Signed-off-by: Waleed Malik ahmedwaleedmalik@gmail.com

What this PR does / why we need it:
This PR does the following:

  • Remove support for k8s v1.24
  • Remove support for docker since it's not supported by upstream anymore.

Which issue(s) this PR fixes:

Fixes #249

What type of PR is this?

/kind cleanup

Special notes for your reviewer:
I intentionally didn't update the versions for OSP since we'll update them only once before the release.

Does this PR introduce a user-facing change? Then add your Release Note here:

Remove support for docker as supported container runtime

Documentation:

https://github.com/kubermatic/docs/pull/1290

Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Jan 5, 2023
@kubermatic-bot kubermatic-bot added docs/provided Denotes a PR that has a valid documentation reference. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jan 5, 2023
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added sig/osm Denotes a PR or issue as being assigned to SIG OSM. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 5, 2023
@kron4eg
Copy link
Member

kron4eg commented Jan 5, 2023

/lgtm

🎉

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fad92496079609d2146b2428d2854bd4fec39c43

@kubermatic-bot kubermatic-bot merged commit e54a0cd into kubermatic:main Jan 5, 2023
@ahmedwaleedmalik ahmedwaleedmalik deleted the drop-docker-support branch January 5, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/provided Denotes a PR that has a valid documentation reference. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/osm Denotes a PR or issue as being assigned to SIG OSM. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support for docker container runtime
3 participants