Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Go 1.20.1 #266

Merged
merged 3 commits into from
Feb 28, 2023
Merged

Upgrade to Go 1.20.1 #266

merged 3 commits into from
Feb 28, 2023

Conversation

ahmedwaleedmalik
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik commented Feb 28, 2023 •
edited
Loading

What this PR does / why we need it:
Upgrade to Go 1.20.1.

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?

/kind feature
/kind chore

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Operating System Manager is now built using Go 1.20.1

Documentation:

NONE

@ahmedwaleedmalik
Update to Go 1.20.1
f3e629a 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Feb 28, 2023
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. docs/none Denotes a PR that doesn't need documentation (changes). dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/osm Denotes a PR or issue as being assigned to SIG OSM. labels Feb 28, 2023
@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubermatic-bot kubermatic-bot added kind/chore Updating grunt tasks etc; no production code changes. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 28, 2023
@ahmedwaleedmalik
Copy link
Member Author

/test all

@kubermatic-bot kubermatic-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 28, 2023
@ahmedwaleedmalik
Upgrade to Alpine 3.17
6baa26a 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik ahmedwaleedmalik marked this pull request as ready for review February 28, 2023 15:47
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 28, 2023
@ahmedwaleedmalik
Allow code to be built with 1.19
ed80cd1 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
xrstf
xrstf approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@xrstf xrstf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2023
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0d6bcaeefc7cfb669649cc4a0319fa7ddbe48309

@kubermatic-bot kubermatic-bot merged commit 790cd91 into kubermatic:main Feb 28, 2023
@ahmedwaleedmalik ahmedwaleedmalik deleted the go-1.20 branch February 28, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrstf xrstf xrstf approved these changes

Assignees

@xrstf xrstf

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/chore Updating grunt tasks etc; no production code changes. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/osm Denotes a PR or issue as being assigned to SIG OSM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahmedwaleedmalik @kubermatic-bot @xrstf