Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v1.1] Avoid second run for bootstrap script #274

Merged
merged 1 commit into from
Mar 14, 2023
Merged

[release/v1.1] Avoid second run for bootstrap script #274

merged 1 commit into from
Mar 14, 2023

Conversation

ahmedwaleedmalik
Copy link
Member

What this PR does / why we need it:
Manual backport for #273

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?

/kind bug

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Fix an issue where cloud-init scripts re-ran on machine reboot

Documentation:

NONE

@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Mar 14, 2023
@kubermatic-bot kubermatic-bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/osm Denotes a PR or issue as being assigned to SIG OSM. labels Mar 14, 2023
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2023
@ahmedwaleedmalik ahmedwaleedmalik changed the title Avoid second run for bootstrap script [release/v1.1] Avoid second run for bootstrap script Mar 14, 2023
@kubermatic-bot kubermatic-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 14, 2023
@ahmedwaleedmalik
Avoid second run for bootstrap script
71116a0 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
moadqassem
moadqassem approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@moadqassem moadqassem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 22bac3b1afcd54dda7497ff68079354dda10e38e

@kubermatic-bot kubermatic-bot merged commit 991f123 into kubermatic:release/v1.1 Mar 14, 2023
@ahmedwaleedmalik ahmedwaleedmalik deleted the release-v1.1/fix-reboot branch March 14, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moadqassem moadqassem moadqassem approved these changes

Assignees

@moadqassem moadqassem

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/osm Denotes a PR or issue as being assigned to SIG OSM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahmedwaleedmalik @kubermatic-bot @moadqassem