Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flatcar cloud-init OSP: fix setting up kernel for kubelet #283

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Flatcar cloud-init OSP: fix setting up kernel for kubelet #283

merged 1 commit into from
Apr 5, 2023

Conversation

LittleFox94
Copy link
Contributor

What this PR does / why we need it:

Fixes the kernel configuration needed for kubelet.

Was re-added as part of the kubelet unit in #272, but the output redirection is not interpreted by systemd, which instead just passes it as arguments to echo.

Also see kubermatic/machine-controller#1582 (comment) where I uncovered this.

What type of PR is this?

/kind bug

Special notes for your reviewer:

I'm pretty sure I tested that change before, no clue what went wrong .. leaving this PR here as a draft and gonna test it and only after that succeeds will remove the draft status.

Does this PR introduce a user-facing change? Then add your Release Note here:

NONE

Documentation:

NONE

@LittleFox94
Flatcar cloud-init OSP: fix setting up kernel for kubelet
7b7b420 
The output redirection added in kubermatic#272 is not interpreted by systemd,
which instead just passes it as arguments to echo.

Signed-off-by: Mara Sophie Grosch <mgrosch@anexia-it.com>
@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. docs/none Denotes a PR that doesn't need documentation (changes). dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/osm Denotes a PR or issue as being assigned to SIG OSM. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 5, 2023
@kubermatic-bot
Copy link
Contributor

Hi @LittleFox94. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 5, 2023
@LittleFox94
Copy link
Contributor Author

I tested this now and it works, again pretty sure I tested this last time as well though ^^'

Anyway, ready for review @ahmedwaleedmalik :)

@LittleFox94 LittleFox94 marked this pull request as ready for review April 5, 2023 11:15
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 5, 2023
@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Apr 5, 2023
ahmedwaleedmalik
ahmedwaleedmalik approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

This looks good, let's hope this is all that we need. :D I'll re-run the Anexia tests on that MC PR once this is merged.

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 981f3e949c42032f4c3e6ca74699d72ca4c698f5

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, LittleFox94

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2023
@kubermatic-bot kubermatic-bot merged commit cc78eef into kubermatic:main Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/osm Denotes a PR or issue as being assigned to SIG OSM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LittleFox94 @kubermatic-bot @ahmedwaleedmalik