Enable IPv6 forwarding in default OSPs #298
Conversation
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
kubermatic-bot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmedwaleedmalik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
approved
| # Configure Linux to accept router advertisements to ensure the default | ||
| # IPv6 route is not removed from the routing table when the Docker service starts. | ||
| # For more information: https://github.com/docker/for-linux/issues/844 | ||
| net.ipv6.conf.all.accept_ra = 2 |
There was a problem hiding this comment.
net.ipv6.conf.all.accept_ra = 2
@moadqassem @WeirdMachine we had a similar fix for flatcar through #198 but i'm wondering if we really need this. Maybe this should be up to the user to configure in case route advertisement fails. Since this is something that'd be governed by the upstream network so eventually the cloud provider.
There was a problem hiding this comment.
I agree, the user should decide how the traffic is forward across different cloud provider. I mean in general we can include this in an if statement
There was a problem hiding this comment.
In my opinion it makes not really sense for Kubernetes workers to not accept RA.
|
LGTM label has been added. Git tree hash: f8d5b5e4818dd8fc4f30ddcbbc438e8b45a2a7a9
|
|
/hold |
kubermatic-bot
added
the
do-not-merge/hold
|
/cherrypick release/v1.3 |
|
@ahmedwaleedmalik: new pull request created: #299 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Enable forwarding for IPv6 interfaces if the machines support IPv6.
Which issue(s) this PR fixes:
Fixes #
What type of PR is this?
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: