Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Go 1.21.3 #325

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Upgrade to Go 1.21.3 #325

merged 1 commit into from
Oct 24, 2023

Conversation

ahmedwaleedmalik
Copy link
Member

What this PR does / why we need it:
Upgrade to Go 1.21.3.

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?

/kind chore

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

OSM is now built using Go 1.21.3

Documentation:

NONE

@ahmedwaleedmalik
Upgrade to Go 1.21.3
ae5022c 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Oct 23, 2023
@kubermatic-bot kubermatic-bot added kind/chore Updating grunt tasks etc; no production code changes. release-note Denotes a PR that will be considered when it comes time to generate release notes. docs/none Denotes a PR that doesn't need documentation (changes). dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/osm Denotes a PR or issue as being assigned to SIG OSM. labels Oct 23, 2023
@kubermatic-bot kubermatic-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 23, 2023
@ahmedwaleedmalik
Copy link
Member Author

/retest

@ahmedwaleedmalik
Copy link
Member Author

/approve

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2023
xmudrii
xmudrii approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3efd180ccf38314fa5cc42433805476f3b63dbe1

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit 2ec3edc into kubermatic:main Oct 24, 2023
12 checks passed
@ahmedwaleedmalik ahmedwaleedmalik deleted the upgrade-go branch October 24, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

@kron4eg kron4eg Awaiting requested review from kron4eg

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/chore Updating grunt tasks etc; no production code changes. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/osm Denotes a PR or issue as being assigned to SIG OSM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahmedwaleedmalik @kubermatic-bot @xmudrii