-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Flatcar on VMware Cloud Director #330
Added support for Flatcar on VMware Cloud Director #330
Conversation
Hi @4ch3los. Thanks for your PR. I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
fccfbf3
to
bb527ad
Compare
…ipt for static ip support on vcloud Signed-off-by: Kai Fink <kai.fink@yahoo.de>
bb527ad
to
9470d2b
Compare
/ok-to-test |
Please also update the compatibility matrix here |
…patibility-matrix Signed-off-by: Kai Fink <kai.fink@yahoo.de>
8a283ce
to
a310aed
Compare
Signed-off-by: Kai Fink <kai.fink@yahoo.de>
Refactored the stuff to match the linting and applied the mentioned things @ahmedwaleedmalik :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 2cc6aaaea626204d615d7360d56b2f7b586cdf77
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmedwaleedmalik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Added and tested flatcar on VMware Cloud Director. There is an extra setup step needed to support static ips. The extra step is executed bootstrap only for VMware Cloud Director and parses the ip information from the vmtoolsd and generates a systemd network config
Which issue(s) this PR fixes:
This PR addresses the osm part of kubermatic/kubermatic#12576
What type of PR is this?
/kind feature
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: