Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for Flatcar on VMware Cloud Director #330

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Added support for Flatcar on VMware Cloud Director #330

merged 3 commits into from
Nov 27, 2023

Conversation

4ch3los
Copy link
Contributor

@4ch3los 4ch3los commented Nov 20, 2023 •
edited

What this PR does / why we need it:
Added and tested flatcar on VMware Cloud Director. There is an extra setup step needed to support static ips. The extra step is executed bootstrap only for VMware Cloud Director and parses the ip information from the vmtoolsd and generates a systemd network config

Which issue(s) this PR fixes:
This PR addresses the osm part of kubermatic/kubermatic#12576

What type of PR is this?
/kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Added support for flatcar on VMware Cloud Director

Documentation:

NONE

@kubermatic-bot kubermatic-bot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. sig/osm Denotes a PR or issue as being assigned to SIG OSM. dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 20, 2023
@kubermatic-bot
Copy link
Contributor

Hi @4ch3los. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. docs/none Denotes a PR that doesn't need documentation (changes). and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. labels Nov 20, 2023
@4ch3los 4ch3los force-pushed the feature/flatcar-vmware-cloud-director branch from fccfbf3 to bb527ad Compare November 20, 2023 12:53
@4ch3los
Added VCloud as supported Provider and implemented optional Setup scr…
9470d2b 
…ipt for static ip support on vcloud

Signed-off-by: Kai Fink <kai.fink@yahoo.de>
@4ch3los 4ch3los force-pushed the feature/flatcar-vmware-cloud-director branch from bb527ad to 9470d2b Compare November 20, 2023 12:56
@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. and removed dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. labels Nov 20, 2023
@4ch3los 4ch3los mentioned this pull request Nov 20, 2023
Merged
ahmedwaleedmalik
ahmedwaleedmalik requested changes Nov 22, 2023
View reviewed changes
deploy/osps/default/osp-flatcar.yaml Outdated Show resolved Hide resolved
deploy/osps/default/osp-flatcar.yaml Outdated Show resolved Hide resolved
@ahmedwaleedmalik
Copy link
Member

/ok-to-test

@kubermatic-bot kubermatic-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 22, 2023
@ahmedwaleedmalik
Copy link
Member

Please also update the compatibility matrix here
https://github.com/kubermatic/operating-system-manager/blob/main/docs/compatibility-matrix.md

@kubermatic-bot kubermatic-bot added dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. and removed dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Nov 24, 2023
@4ch3los
Refactored naming, placed systectl restart in if block & adjusted com…
a310aed 
…patibility-matrix

Signed-off-by: Kai Fink <kai.fink@yahoo.de>
@4ch3los 4ch3los force-pushed the feature/flatcar-vmware-cloud-director branch from 8a283ce to a310aed Compare November 24, 2023 21:05
@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. and removed dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. labels Nov 24, 2023
@4ch3los
Fixed styling to match yaml lint
65f6541 
Signed-off-by: Kai Fink <kai.fink@yahoo.de>
@4ch3los
Copy link
Contributor Author

4ch3los commented Nov 24, 2023

Refactored the stuff to match the linting and applied the mentioned things @ahmedwaleedmalik :)

ahmedwaleedmalik
ahmedwaleedmalik approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2cc6aaaea626204d615d7360d56b2f7b586cdf77

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2023
@kubermatic-bot kubermatic-bot merged commit 9577f1f into kubermatic:main Nov 27, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/osm Denotes a PR or issue as being assigned to SIG OSM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@4ch3los @kubermatic-bot @ahmedwaleedmalik