-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Kubernetes v1.29 #344
Conversation
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
3341482
to
3ac6c5c
Compare
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 7d0f1a675c1ba8f48d7c491accdfc3c7a9767f16
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR adds the required changes for supporting k8s v1.29. With k8s 1.29, in-tree cloud providers have been disabled by default. To enable that functionality we need to turn off
DisableCloudProviders
feature gate.We have added a special case/flag in order to determine if that feature gate has been disabled. This can be used to enable in-tree CCM functionality if required. We need this to run machine-controller e2e tests.
Which issue(s) this PR fixes:
Fixes #
What type of PR is this?
/kind feature
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: