Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Kubernetes v1.29 #344

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

ahmedwaleedmalik
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik commented Jan 8, 2024

What this PR does / why we need it:
This PR adds the required changes for supporting k8s v1.29. With k8s 1.29, in-tree cloud providers have been disabled by default. To enable that functionality we need to turn off DisableCloudProviders feature gate.

We have added a special case/flag in order to determine if that feature gate has been disabled. This can be used to enable in-tree CCM functionality if required. We need this to run machine-controller e2e tests.

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?

/kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Support for Kubernetes v1.29

Documentation:

https://github.com/kubermatic/docs/pull/1598

@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Jan 8, 2024
@kubermatic-bot kubermatic-bot added docs/tbd Denotes a PR that needs documentation (change) that will be done later. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. labels Jan 8, 2024
@kubermatic-bot kubermatic-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 8, 2024
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
Copy link
Contributor

@xrstf xrstf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7d0f1a675c1ba8f48d7c491accdfc3c7a9767f16

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2024
@kubermatic-bot kubermatic-bot merged commit b178a7f into kubermatic:main Jan 8, 2024
11 checks passed
@ahmedwaleedmalik ahmedwaleedmalik deleted the k8s-1.29 branch January 8, 2024 11:02
@kubermatic-bot kubermatic-bot added docs/provided Denotes a PR that has a valid documentation reference. and removed docs/tbd Denotes a PR that needs documentation (change) that will be done later. labels Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/provided Denotes a PR that has a valid documentation reference. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants