Cloud-config is not required for external cloud providers #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubermatic-bot
added
kind/bug
ahmedwaleedmalik
force-pushed
the
external-cloud-config
branch
from
c96306e
to
6f945c4
Compare
|
/retest |
ahmedwaleedmalik
force-pushed
the
external-cloud-config
branch
3 times, most recently
from
dfb9c00
to
2f48f5a
Compare
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
ahmedwaleedmalik
force-pushed
the
external-cloud-config
branch
from
2f48f5a
to
37da6bd
Compare
kubermatic-bot
added
size/L
This was referenced Feb 13, 2024
|
LGTM label has been added. Git tree hash: ebf73962772a2913369c6dc2c1fa79c8cd1dd5d0
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Cloud-config is no longer generated for external cloud providers and for clusters that are on k8s v1.29 or higher.
Which issue(s) this PR fixes:
Fixes #
What type of PR is this?
/kind bug
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: