-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloud-config is not required for external cloud providers #353
Cloud-config is not required for external cloud providers #353
Conversation
c96306e
to
6f945c4
Compare
/retest |
dfb9c00
to
2f48f5a
Compare
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
2f48f5a
to
37da6bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: ebf73962772a2913369c6dc2c1fa79c8cd1dd5d0
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Cloud-config is no longer generated for external cloud providers and for clusters that are on k8s v1.29 or higher.
Which issue(s) this PR fixes:
Fixes #
What type of PR is this?
/kind bug
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: