-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove hard dependency on torcx, removed in Flatcar 3815.2.0 #357
Remove hard dependency on torcx, removed in Flatcar 3815.2.0 #357
Conversation
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
/hold I'm doing some manual testing on older flatcar versions to ensure this change is compatible. |
/lgtm |
LGTM label has been added. Git tree hash: f0680437f5bf0f5c4c1acf5c05ef1f3ec76dc852
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kron4eg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release/v1.4 |
@embik: once the present PR merges, I will cherry-pick it on top of release/v1.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release/v1.3 |
@embik: once the present PR merges, I will cherry-pick it on top of release/v1.3 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release/v1.2 |
@embik: once the present PR merges, I will cherry-pick it on top of release/v1.2 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold cancel Everything looking good. Tested this with 3374.2.2 and 3815.2.0. |
@embik: #357 failed to apply on top of branch "release/v1.4":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@embik: #357 failed to apply on top of branch "release/v1.3":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@embik: #357 failed to apply on top of branch "release/v1.2":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…15.2.0 (kubermatic#357) Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
What this PR does / why we need it:
We ran into the issue described in #335 - Flatcar's release of 3815.2.0 broke our OSP because we depend on torcx being available. It has been removed in this Flatcar version though.
This PR is an attempt at making the least amount of changes to the systemd drop-in we use while maximising compatibility with old Flatcar images - If torcx is still there because you are running a very old version of Flatcar, this will keep using it by giving priority to the TORCX_BINDIR sourced from
/run/metadata/torcx
, but since we are making sourcing environment variables from that file optional (with the-
prefix), it might be very well empty (which is the case for newer Flatcar versions).Which issue(s) this PR fixes:
Fixes #335
What type of PR is this?
/kind bug
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: