Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid second run of bootstrap script for flatcar with cloud-init #365

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Avoid second run of bootstrap script for flatcar with cloud-init #365

merged 1 commit into from
Feb 27, 2024

Conversation

ahmedwaleedmalik
Copy link
Member

What this PR does / why we need it:
Extending #273 and including the fix in flatcar-cloud-init OSP as well.

Which issue(s) this PR fixes:

Fixes #364

What type of PR is this?

/kind bug

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Fix an issue where cloud-init scripts re-ran on machine reboot

Documentation:

NONE

@ahmedwaleedmalik
Avoid second run of bootstrap script for flatcar with cloud-init
dd8f2d7 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Feb 27, 2024
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. docs/none Denotes a PR that doesn't need documentation (changes). dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 27, 2024
@ahmedwaleedmalik ahmedwaleedmalik mentioned this pull request Feb 27, 2024
Closed
@kron4eg
Copy link
Member

kron4eg commented Feb 27, 2024

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 701e20d3f4016d660f257f1a873b3643e58c3e02

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2024
@kubermatic-bot kubermatic-bot merged commit 44cf897 into kubermatic:main Feb 27, 2024
11 checks passed
@ahmedwaleedmalik ahmedwaleedmalik deleted the avoid-second-run branch February 27, 2024 21:39
@ghost
Copy link

ghost commented Feb 28, 2024

Hi @ahmedwaleedmalik,
thank you for fixing this issue!
Could we please have this backported to v1.3 & v1.4?

@ahmedwaleedmalik
Copy link
Member Author

/cherry-pick release/v1.3

@kubermatic-bot
Copy link
Contributor

@ahmedwaleedmalik: new pull request created: #366

In response to this:

/cherry-pick release/v1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot mentioned this pull request Feb 28, 2024
Merged
@ahmedwaleedmalik
Copy link
Member Author

/cherry-pick release/v1.4

@kubermatic-bot
Copy link
Contributor

@ahmedwaleedmalik: new pull request created: #367

In response to this:

/cherry-pick release/v1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot mentioned this pull request Feb 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg Awaiting requested review from kron4eg

@moadqassem moadqassem Awaiting requested review from moadqassem

Assignees

@kron4eg kron4eg

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

osp-flatcar-cloud-init unstable after reboot
3 participants
@ahmedwaleedmalik @kron4eg @kubermatic-bot