Fix: Support vmtoolsd from $PATH

[4ch3los]

What this PR does / why we need it:

This PR adjusts the osp for flatcar on VMware cloud director. We now use the vmtoolsd binary from Path by default and only fallback to the old path if it does not exist. This is needed as newer flatcar releases have moved the binary to another location.

What type of PR is this?

/kind bug

Special notes for your reviewer:

Backwards compatibility is kept by falling back to the old path if binary was not found in $PATH

Does this PR introduce a user-facing change? Then add your Release Note here:

Fixes the network setup on vmware cloud director with flatcar, pool ips and the latest images 

Documentation:

NONE

[kubermatic-bot]

Hi @4ch3los. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kron4eg]

It's a matter of taste of course, I'd just add /usr/share/oem/bin/ to the $PATH and run vmtoolsd without pathprefix

[kron4eg]

/cc @ahmedwaleedmalik

[ahmedwaleedmalik]

/approve

[kubermatic-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ahmedwaleedmalik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ahmedwaleedmalik]

pull-operating-system-manager-yamllint

./deploy/osps/default/osp-flatcar.yaml
  58:1      error    trailing spaces  (trailing-spaces)

/lgtm cancel

@4ch3los can you please take a look

[kron4eg]

/test pull-operating-system-manager-yamllint

[kron4eg]

/lgtm

[kubermatic-bot]

LGTM label has been added.

Git tree hash: d8b24ff54905d51786c65f61b53a1b936c1d35c1