-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Support vmtoolsd from $PATH #368
Fix: Support vmtoolsd from $PATH #368
Conversation
…tools to another location Signed-off-by: Kai Fink <kai.fink@yahoo.de>
Hi @4ch3los. Thanks for your PR. I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
It's a matter of taste of course, I'd just add /usr/share/oem/bin/ to the $PATH and run |
Signed-off-by: Kai Fink <kai.fink@yahoo.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmedwaleedmalik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm cancel @4ch3los can you please take a look |
Signed-off-by: Kai Fink <kai.fink@yahoo.de>
/test pull-operating-system-manager-yamllint |
/lgtm |
LGTM label has been added. Git tree hash: d8b24ff54905d51786c65f61b53a1b936c1d35c1
|
What this PR does / why we need it:
This PR adjusts the osp for flatcar on VMware cloud director. We now use the vmtoolsd binary from Path by default and only fallback to the old path if it does not exist. This is needed as newer flatcar releases have moved the binary to another location.
What type of PR is this?
/kind bug
Special notes for your reviewer:
Backwards compatibility is kept by falling back to the old path if binary was not found in $PATH
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: