Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update golang to 1.22.2 #374

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Update golang to 1.22.2 #374

merged 2 commits into from
Apr 10, 2024

Conversation

akash-gautam
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?
/kind chore

Does this PR introduce a user-facing change? Then add your Release Note here:

OSM is now built using Go 1.22.2

Documentation:

NONE

@akash-gautam
update golang to 1.22.2
1d697a8 
Signed-off-by: Akash Gautam <gautamakash04@gmail.com>
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/chore Updating grunt tasks etc; no production code changes. docs/none Denotes a PR that doesn't need documentation (changes). dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 10, 2024
@akash-gautam
fix lint test failures port golang 1.22.2 upgrade
ec5f617 
Signed-off-by: Akash Gautam <gautamakash04@gmail.com>
embik
embik approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: eba88a801e68de4badab4dae380586ed4885f234

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2024
@kubermatic-bot kubermatic-bot merged commit 816dfd4 into kubermatic:main Apr 10, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@embik embik embik approved these changes

Assignees

@embik embik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/chore Updating grunt tasks etc; no production code changes. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@akash-gautam @kubermatic-bot @embik