Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the Valgrind memory check for examples #133

Merged
merged 2 commits into from
Aug 17, 2022
Merged

Add the Valgrind memory check for examples #133

merged 2 commits into from
Aug 17, 2022

Conversation

ityuhui
Copy link
Member

@ityuhui ityuhui commented Aug 12, 2022

Close #67

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 12, 2022
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 12, 2022
@ityuhui ityuhui changed the title Add valgrind memory tests for examples Add the Valgrind memory tests for examples Aug 12, 2022
@ityuhui ityuhui force-pushed the yh-memory-test-0812 branch from df84fdd to f5dad02 Compare August 12, 2022 06:45
@ityuhui
Copy link
Member Author

ityuhui commented Aug 12, 2022

/cc @brendandburns

@ityuhui ityuhui force-pushed the yh-memory-test-0812 branch from f5dad02 to 3fe8c8b Compare August 12, 2022 06:57
@ityuhui ityuhui changed the title Add the Valgrind memory tests for examples Add the Valgrind memory check for examples Aug 12, 2022
brendandburns
brendandburns reviewed Aug 15, 2022
View reviewed changes
examples/Makefile Outdated Show resolved Hide resolved
@brendandburns
Copy link
Contributor

One small comment/question otherwise lgtm.

@ityuhui ityuhui force-pushed the yh-memory-test-0812 branch from 32adc86 to fd7fbe5 Compare August 17, 2022 02:25
@brendandburns
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, ityuhui

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [brendandburns,ityuhui]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4e38e72 into kubernetes-client:master Aug 17, 2022
@ityuhui ityuhui deleted the yh-memory-test-0812 branch August 18, 2022 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendandburns brendandburns brendandburns left review comments

Assignees

@brendandburns brendandburns

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate valgrind memory check into github/actions
3 participants
@ityuhui @brendandburns @k8s-ci-robot