Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for the presence of secure_getenv #163

Merged

Conversation

irozzo-1A
Copy link
Contributor

This change introduces support for glibc versions older than 2.17 where secure_getenv was introduced.

This change introduces support for glibc versions older than 2.17 where
secure_getenv was introduced.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 29, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @irozzo-1A!

It looks like this is your first PR to kubernetes-client/c 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/c has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 29, 2022
@brendandburns
Copy link
Contributor

This looks good to me. I will wait for @ityuhui to have a look also before we merge.

Thanks for the PR!

@ityuhui
Copy link
Member

ityuhui commented Dec 30, 2022

It's good to me too.
But I think there is a small problem in the previous code (even though it has no effect on the functionality):

config.h.in

/* Define to 1 if you have the `strndup' function. */
#cmakedefine HAVE_STRNDUP 1
#cmakedefine HAVE_SECURE_GETENV 1

The code should change to

#cmakedefine HAVE_STRNDUP
#cmakedefine HAVE_SECURE_GETENV

because the HAVE_STRNDUP and HAVE_SECURE_GETENV are determined by
kubernetes/ConfigureChecks.cmake

check_function_exists(strndup HAVE_STRNDUP)
check_function_exists(secure_getenv HAVE_SECURE_GETENV)

I'll submit another PR to update it.

@ityuhui
Copy link
Member

ityuhui commented Dec 30, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 30, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irozzo-1A, ityuhui

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 30, 2022
@k8s-ci-robot k8s-ci-robot merged commit 0525735 into kubernetes-client:master Dec 30, 2022
@ityuhui
Copy link
Member

ityuhui commented Dec 30, 2022

Thanks for this PR !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants