-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check for the presence of secure_getenv #163
Add check for the presence of secure_getenv #163
Conversation
This change introduces support for glibc versions older than 2.17 where secure_getenv was introduced.
Welcome @irozzo-1A! |
This looks good to me. I will wait for @ityuhui to have a look also before we merge. Thanks for the PR! |
It's good to me too. config.h.in /* Define to 1 if you have the `strndup' function. */
#cmakedefine HAVE_STRNDUP 1
#cmakedefine HAVE_SECURE_GETENV 1 The code should change to #cmakedefine HAVE_STRNDUP
#cmakedefine HAVE_SECURE_GETENV because the check_function_exists(strndup HAVE_STRNDUP)
check_function_exists(secure_getenv HAVE_SECURE_GETENV) I'll submit another PR to update it. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: irozzo-1A, ityuhui The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for this PR ! |
This change introduces support for glibc versions older than 2.17 where secure_getenv was introduced.