Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct check for getenv()/secure_getenv() #171

Merged
merged 4 commits into from
Feb 11, 2023
Merged

Correct check for getenv()/secure_getenv() #171

merged 4 commits into from
Feb 11, 2023

Conversation

ahmedyarub
Copy link
Contributor

I encountered this building for Android. Android doesn't have neither function.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 8, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 8, 2023
@ahmedyarub ahmedyarub marked this pull request as draft February 8, 2023 23:57
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 8, 2023
@brendandburns
Copy link
Contributor

Minor comments, and CI is failing.

@ahmedyarub
Copy link
Contributor Author

Minor comments, and CI is failing.

It's weird because on my machine the tests do pass! I'll keep on investigating...

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 10, 2023
@ahmedyarub ahmedyarub marked this pull request as ready for review February 10, 2023 01:36
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 10, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 10, 2023
@ahmedyarub
Copy link
Contributor Author

I introduced function/symbol tests last year but I have just found that my implementation is wrong although everything was working! This is the correct implementation for checking getenv, secure_getenv, and strndup.

@brendandburns
Copy link
Contributor

This looks good to me. Thanks for the updates.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 11, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedyarub, brendandburns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2023
@k8s-ci-robot k8s-ci-robot merged commit 488460f into kubernetes-client:master Feb 11, 2023
@ahmedyarub ahmedyarub deleted the ay/fix_android_build branch February 11, 2023 18:57
@ityuhui ityuhui mentioned this pull request Mar 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ityuhui ityuhui Awaiting requested review from ityuhui

@brendandburns brendandburns Awaiting requested review from brendandburns

Assignees

@brendandburns brendandburns

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahmedyarub @brendandburns @k8s-ci-robot