-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix([README.md]): typos in README.md causes installation error #186
Conversation
The following description in README.md might causes ambiguous parsing during cmake code building: cmake -DLWS_WITHOUT_TESTAPPS=ON -DLWS_WITHOUT_TEST_SERVER=ON-DLWS_WITHOUT_TEST_SERVER_EXTPOLL=ON. split -D from SERVER=ON
|
Welcome @rexlim820220! |
Thank you @rexlim820220 Can you please follow the guidelines to sign CLA ? |
@ity
will be spending time figuring it out, thanks |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ityuhui, rexlim820220 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
The following description in README.md might causes ambiguous parsing during cmake code building:
What is the behavior?
While copying above commands to Dockerfile, error was encountered.
The code is built in Docker under CentOS Linux release 7.7.1908 (Core) with cmake version 3.6.2.
Advise
A maybe nicer description would be splitting -D from SERVER=ON, which makes the command less ambiguous.
/label ~bug ~reproduced ~needs-investigation