Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use int* as int or bool type function parameters #210

Merged
merged 3 commits into from
Dec 21, 2023

Conversation

ityuhui
Copy link
Member

@ityuhui ityuhui commented Dec 14, 2023

fixes: #209

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 14, 2023
@ityuhui
Copy link
Member Author

ityuhui commented Dec 14, 2023

/cc @brendandburns

@ityuhui
Copy link
Member Author

ityuhui commented Dec 21, 2023

Ping @brendandburns in case this PR is ignored…

@brendandburns
Copy link
Contributor

/lgtm
/approve

Apologies for the delay, it's the winter holidays around here so responses are likely to be delayed.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 21, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, ityuhui

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [brendandburns,ityuhui]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1315831 into kubernetes-client:master Dec 21, 2023
8 checks passed
@ityuhui ityuhui deleted the yh-intstar-1214 branch December 22, 2023 01:24
@ityuhui
Copy link
Member Author

ityuhui commented Dec 22, 2023

Happy Holidays ! Thank you for your guidance and help this year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CoreV1API_listPodForAllNamespaces/CoreV1API_listNamespacedPod API return 422 error
3 participants