Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed pod logs core api request errors. #227

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed pod logs core api request errors. #227

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions kubernetes/api/CoreV1API.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35170,7 +35170,7 @@ CoreV1API_readNamespacedPodLog(apiClient_t *apiClient, char *name, char *_namesp
keyPairQuery_timestamps = keyValuePair_create(keyQuery_timestamps, valueQuery_timestamps);
list_addElement(localVarQueryParameters,keyPairQuery_timestamps);
}
list_addElement(localVarHeaderType,"text/plain"); //produces
//list_addElement(localVarHeaderType,"text/plain"); //produces removed text/plain as it is rejected
Copy link
Member

@ityuhui ityuhui Mar 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't comment this line, will the result be correct? I don't think this should affect the results.

The text/plain header is defined in the Kubernetes OpenAPI spec. This line is automatically gnereated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that header is sent, it'll respond with a 400-level instead of a 200. The comment is needed to ensure that the header is not sent.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. I'll try this API.

list_addElement(localVarHeaderType,"application/json"); //produces
list_addElement(localVarHeaderType,"application/yaml"); //produces
list_addElement(localVarHeaderType,"application/vnd.kubernetes.protobuf"); //produces
Expand All @@ -35193,9 +35193,11 @@ CoreV1API_readNamespacedPodLog(apiClient_t *apiClient, char *name, char *_namesp
// printf("%s\n","Unauthorized");
//}
//primitive return type simple
char* elementToReturn = strdup((char*)apiClient->dataReceived);
char* elementToReturn = NULL;
Copy link
Member

@ityuhui ityuhui Mar 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good catch !
Can you make code changes in the upstream code generator instead of here?

https://github.com/OpenAPITools/openapi-generator/blob/ae9084bfd6bf03d3ef1fff1cdb52d04b008f9621/modules/openapi-generator/src/main/resources/C-libcurl/api-body.mustache#L362

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is for your reference: OpenAPITools/openapi-generator#17540


if (apiClient->dataReceived) {
// moved strdup inside the guard to prevent segfaults on NULL dataReceived
elementToReturn = strdup((char*)apiClient->dataReceived);
free(apiClient->dataReceived);
apiClient->dataReceived = NULL;
apiClient->dataReceivedLen = 0;
Expand Down
Loading