-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support to load kubernetes configuration for memory buffer #242
base: master
Are you sure you want to change the base?
Changes from 4 commits
6d3bd66
8f759fc
34d1b13
4a19bc2
70f05e5
1d79e0f
2525271
fb4170b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,13 +24,17 @@ extern "C" { | |
* | ||
* IN: | ||
* kubeconfig->fileName: kubernetes cluster configuration file name | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe note that either one, but not both should be supplied? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I have added a more explicit note there. There was already a hint in the doc for kubeconfig->buffer.
|
||
* | ||
* kubeconfig->buffer: kubernetes cluster configuration data; this is considered only if kubeconfig->fileName is set to NULL | ||
* | ||
* Note: One may use either kubeconfig->fileName or kubeconfig->buffer but not both at the same time. | ||
* | ||
* OUT: | ||
* kubeconfig: kubernetes cluster configuration | ||
* | ||
*/ | ||
int kubeyaml_load_kubeconfig(kubeconfig_t * kubeconfig); | ||
|
||
|
||
/* | ||
* kubeyaml_parse_exec_crendential | ||
* | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a test here to verify that only one of
fileName
andbuffer
is non-null.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.