-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bazel files to support Bazel integration #254
Add Bazel files to support Bazel integration #254
Conversation
BUILD
Outdated
# deps = [":kube_c"], | ||
# ) | ||
|
||
# Make sure you install the pre-requisites (libyaml,libwebsocket etc.) beforehand. A working example can be found here https://github.com/joyanta55/kubernetes_c_bazel/tree/main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: line break before the URL
Can you add a workflow to our Github Actions CI/CD that exercises this build file? Otherwise, I worry that it will bit-rot if it isn't tested regularly. Otherwise, small nit and then LGTM. |
(oh, and thanks!) |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, joyanta55 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Added
BUILD
file in the kubernetes c client repository that helps integrating the library to externalBazel
users.Following are the changes needed from the external Bazel users to do.
WORKSPACE
file:BUILD
file:The added filegroup allows to import kubernetes C client (i.e.
lib_source = "@kubernetes_c_client//:kubernetes
"), usecmake
ormake
bazel
rule provided byrules_foreign_cc
(https://github.com/bazel-contrib/rules_foreign_cc) to build and use.Make sure you install the pre-requisites (libyaml,libwebsocket etc.) beforehand. A working example can be found here