-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1553 optimise dependencies #1554
#1553 optimise dependencies #1554
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: thompson-tomo The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @thompson-tomo! |
17cc48f
to
cce9c9e
Compare
@@ -1,7 +1,7 @@ | |||
<Project Sdk="Microsoft.NET.Sdk"> | |||
|
|||
<PropertyGroup> | |||
<TargetFrameworks>netstandard2.0;net48</TargetFrameworks> | |||
<TargetFrameworks>netstandard2.0;net48;net6.0</TargetFrameworks> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please elaborate why net6 is added here?
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1554 +/- ##
=========================================
Coverage ? 61.34%
=========================================
Files ? 103
Lines ? 3068
Branches ? 639
=========================================
Hits ? 1882
Misses ? 1186
Partials ? 0 ☔ View full report in Codecov by Sentry. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Have gone and eliminated polyfils packages where possible as in those cases the dependencies are already natively being provided by the framework.
Closes #1553