Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update KubernetesClient DiagnosticSource dependency #1561

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

WeihanLi
Copy link
Contributor

@WeihanLi WeihanLi commented Jun 7, 2024

System.Diagnostics.DiagnosticSource has been included in the framework reference, no need to reference for net8

fixes #1553

System.Diagnostics.DiagnosticSource has been included into the framework reference, no need to reference for net8
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 7, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 7, 2024
@@ -7,7 +7,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="System.Diagnostics.DiagnosticSource" Version="7.0.0" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this is net6 only?

we already moved to net8 lol

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the System.Diagnostics.DiagnosticSource is included in the shared framework, so there's no need to reference this package for most cases.

While we're using the UpDownCounter in the code

private static readonly UpDownCounter<int> ActiveRequests =

The UpDownCounter has been introduced since .NET 7
see the API: https://apisof.net/catalog/c7f52491f5c19b75d271677fe9123886

The shared framework for .NET 6 only has the 6.0.x reference which does not support this UpDownCounter, so we had to add a reference explicitly.

For .NET 7 and later frameworks, we could use the framework reference directly, so no need to add the reference for System.Diagnostics.DiagnosticSource when targeting net8.0 I think

@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@2c2bd6a). Learn more about missing BASE report.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1561   +/-   ##
=========================================
  Coverage          ?   61.50%           
=========================================
  Files             ?      103           
  Lines             ?     3068           
  Branches          ?      639           
=========================================
  Hits              ?     1887           
  Misses            ?     1181           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tg123 tg123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tg123, WeihanLi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 7, 2024
@k8s-ci-robot k8s-ci-robot merged commit b6315d8 into kubernetes-client:master Jun 7, 2024
14 checks passed
@WeihanLi WeihanLi deleted the patch-2 branch June 7, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove polyfil package from net 7/8
4 participants