init cpm support #1565
init cpm support #1565
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
k8s-ci-robot
added
the
do-not-merge/work-in-progress
| @@ -27,7 +26,7 @@ | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Update="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="3.3.2" /> | |||
There was a problem hiding this comment.
This has been removed since it's deprecated and we're using the Microsoft.CodeAnalysis.NetAnalyzers now
warning CA9998: FxCopAnalyzers package has been deprecated in favor of 'Microsoft.CodeAnalysis.NetAnalyzers'
There was a problem hiding this comment.
Does the global package reference for NetAnalyzers ensure that we are doing the same style enforcement for this package? I want to make sure we maintain that style enforcement.
There was a problem hiding this comment.
Think this package may not actually used, only see two references for test projects
| @@ -28,6 +27,6 @@ | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Update="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="3.3.2" /> | |||
There was a problem hiding this comment.
Removed since it's deprecated
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
@brendandburns @tg123 could you please help try to re-run the failed CI, looks good from my CI runs |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tg123, WeihanLi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Use the nuget CPM feature to manage the nuget package versions centrally
https://learn.microsoft.com/en-us/nuget/consume-packages/central-package-management
fixes #1564