Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tcp keep alive hack to net5 target #560

Merged
merged 8 commits into from
Mar 11, 2021
Merged

add tcp keep alive hack to net5 target #560

merged 8 commits into from
Mar 11, 2021

Conversation

tg123
Copy link
Member

@tg123 tg123 commented Feb 12, 2021

this is the temp fix for #533 and net5 only
net5 users will have tcp keepalive by default

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 12, 2021
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 13, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 13, 2021
@tg123
Copy link
Member Author

tg123 commented Feb 13, 2021

#555

@brendandburns
Copy link
Contributor

Looks good, one small comment on documenting things.

(separately, looks like we should exclude tests from the codeql scanning)

@brendandburns
Copy link
Contributor

/check-cla

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, tg123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2021
@k8s-ci-robot k8s-ci-robot merged commit 655a42c into kubernetes-client:master Mar 11, 2021
@tg123 tg123 deleted the net5tempfix branch March 14, 2021 11:20
@brendandburns brendandburns mentioned this pull request Mar 16, 2021
Closed
@brendandburns
Copy link
Contributor

We should perhaps only add keep-alives for sockets used for watch.

@brendandburns
Copy link
Contributor

I think we're hitting this:

dotnet/runtime#24917

@brendandburns
Copy link
Contributor

Perhaps we should switch to HTTP/2 pings?

dotnet/runtime#40257

@tg123
Copy link
Member Author

tg123 commented Mar 17, 2021

I tested this when I first impl the tcp keepalive
at first I think it is tcp keepalive but I am still being kicked out after enable this.

Perhaps we should switch to HTTP/2 pings?

dotnet/runtime#40257

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendandburns brendandburns brendandburns left review comments

@krabhishek8260 krabhishek8260 Awaiting requested review from krabhishek8260

Assignees

@brendandburns brendandburns

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tg123 @brendandburns @k8s-ci-robot