Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support .net 6 for tcp keep alive #777

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Support .net 6 for tcp keep alive #777

merged 1 commit into from
Feb 8, 2022

Conversation

zhiweiv
Copy link
Contributor

@zhiweiv zhiweiv commented Feb 8, 2022

The tcp keep alive only work for .net 5 now, it should work for .net 6 too.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 8, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhiweiv
To complete the pull request process, please assign brendandburns after the PR has been reviewed.
You can assign the PR to them by writing /assign @brendandburns in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 8, 2022
@zhiweiv zhiweiv mentioned this pull request Feb 8, 2022
Closed
@tg123
Copy link
Member

tg123 commented Feb 8, 2022

/LGTM

omg i remember i s/NET5_0/NET5_0_OR_GREATER when upgrading to net6

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2022
@tg123 tg123 merged commit d74f357 into kubernetes-client:master Feb 8, 2022
@zhiweiv zhiweiv deleted the keepalivenet6 branch April 18, 2022 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

@krabhishek8260 krabhishek8260 Awaiting requested review from krabhishek8260

Assignees

@tg123 tg123

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhiweiv @k8s-ci-robot @tg123