-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ad-hoc client generation for CRDs #161
Conversation
Welcome @aespinosa! |
/assign @brendanburns |
@aespinosa: GitHub didn't allow me to assign the following users: brendanburns. Note that only kubernetes-client members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @mbohlool |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aespinosa, brendandburns The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
this is awesome! let me adjust the guide doc on the java repository. |
Only works and tested in java as it's what we are using at the moment.
Introduces the following variables to a
setting
file:KUBERNETES_CRD_MODE
- must be set totrue
to activate the maven profile.OPENAPI_MODEL_LENGTH
- customizes how much prefix of the generated model to strip. Similar to what is done in https://github.com/kubernetes-client/java/blob/master/docs/generate-model-from-third-party-resources.md#generate-java-model-from-the-downloaded-openapi-spec through the-l<n>
flag.KUBERNETES_CRD_GROUP_PREFIX
- the prefix of the apiGroup to filter for the CRDsAnd similar to https://github.com/kubernetes-client/java/blob/master/docs/generate-model-from-third-party-resources.md,
OPENAPI_SKIP_FETCH_SPEC
is needed.Added codepaths in
preprocess_spec.py
to address kubernetes-client/java#921 by replacing the wholeListMeta
tree with$ref: #/definitions/v1.ListMeta
Addresses #121
cc @brendanburns @yue9944882