-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CustomObjectsApi needs enhancement #245
Comments
@rjeberhard , you may be interested in kubernetes-client/gen#59 (comment) |
This is tricky... I'm going to have to think about it a little bit... |
Hi, @brendandburns. Any update on this one? If you look at the conversation in Issue #515 you'll see the gymnastics that are presently necessary to use your own type. In the meantime, we basically copied methods from CoreV1Api, but used the paths from CustomObjectsApi, and then updated to use our custom type. |
just regenerating the client is fine i believe.. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle rotten ref: #609, working on structured CRD client generation |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Presently, we generate our own "Api" class for the type described by our CRD; however, I'd prefer to use the built-in CustomObjectsApi class.
Unfortunately, there is no way to pass in the our Type (and list Type) when constructing or using this class. Also, the list methods are missing parameters like fieldSelector and _continue.
I'm happy to assist with performing the enhancement but would like to know if there is a way to adjust how this class is generated so that we get the enhancements described.
@brendandburns
The text was updated successfully, but these errors were encountered: