Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise CRD generation guides: uses generator script instead of running images #981

Merged
merged 1 commit into from
Jun 19, 2020
Merged

Revise CRD generation guides: uses generator script instead of running images #981

merged 1 commit into from
Jun 19, 2020

Conversation

yue9944882
Copy link
Member

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 18, 2020
@yue9944882 yue9944882 mentioned this pull request Jun 18, 2020
Closed
erikgb
erikgb suggested changes Jun 18, 2020
View reviewed changes
docs/generate-model-from-third-party-resources.md Outdated Show resolved Hide resolved
docs/generate-model-from-third-party-resources.md Outdated Show resolved Hide resolved
docs/generate-model-from-third-party-resources.md Outdated

```
docker run -i --rm yue9944882/java-model-gen -p com.example < /tmp/swagger | tar -xzf - -C /tmp/
Usage: generate a java project using input openapi spec from stdin
-c: project version of the generated java project.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by the "project version"? Could the option documentation be re-worded for better understanding?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed the line as this looks like a rarely used option 🤔

@yue9944882
update CRD generation guides
97eb1ab 
Update docs/generate-model-from-third-party-resources.md

Co-authored-by: Erik Godding Boye <1142578+erikgb@users.noreply.github.com>

Update docs/generate-model-from-third-party-resources.md

Co-authored-by: Erik Godding Boye <1142578+erikgb@users.noreply.github.com>

fold -c flag explaination
@brendandburns
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, yue9944882

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [brendandburns,yue9944882]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f6064e2 into kubernetes-client:master Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikgb erikgb erikgb requested changes

@brendandburns brendandburns Awaiting requested review from brendandburns

Assignees

@brendandburns brendandburns

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yue9944882 @brendandburns @k8s-ci-robot @erikgb