Skip to content

Commit

Permalink
fixup! fixup! fixup! fixup! fixup! fix(cache): update cache with O(1)…
Browse files Browse the repository at this point in the history
… data structures
  • Loading branch information
bbatha committed Mar 1, 2022
1 parent 8cf1660 commit 15e74b9
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions src/cache.ts
Original file line number Diff line number Diff line change
Expand Up @@ -255,8 +255,8 @@ export function deleteItems<T extends KubernetesObject>(
export function addOrUpdateObject<T extends KubernetesObject>(
objects: CacheMap<T>,
obj: T,
addCallback?: Array<ObjectCallback<T>>,
updateCallback?: Array<ObjectCallback<T>>,
addCallbacks?: Array<ObjectCallback<T>>,
updateCallbacks?: Array<ObjectCallback<T>>,
): void {
let namespaceObjects = objects.get(obj.metadata!.namespace || '');
if (!namespaceObjects) {
Expand All @@ -268,14 +268,14 @@ export function addOrUpdateObject<T extends KubernetesObject>(
const found = namespaceObjects.get(name);
if (!found) {
namespaceObjects.set(name, obj);
if (addCallback) {
addCallback.forEach((elt: ObjectCallback<T>) => elt(obj));
if (addCallbacks) {
addCallbacks.forEach((elt: ObjectCallback<T>) => elt(obj));
}
} else {
if (!isSameVersion(found, obj)) {
namespaceObjects.set(name, obj);
if (updateCallback) {
updateCallback.forEach((elt: ObjectCallback<T>) => elt(obj));
if (updateCallbacks) {
updateCallbacks.forEach((elt: ObjectCallback<T>) => elt(obj));
}
}
}
Expand All @@ -293,7 +293,7 @@ function isSameVersion<T extends KubernetesObject>(o1: T, o2: T): boolean {
export function deleteObject<T extends KubernetesObject>(
objects: CacheMap<T>,
obj: T,
deleteCallback?: Array<ObjectCallback<T>>,
deleteCallbacks?: Array<ObjectCallback<T>>,
): void {
const namespace = obj.metadata!.namespace || '';
const name = obj.metadata!.name || '';
Expand All @@ -304,8 +304,8 @@ export function deleteObject<T extends KubernetesObject>(
}
const deleted = namespaceObjects.delete(name);
if (deleted) {
if (deleteCallback) {
deleteCallback.forEach((elt: ObjectCallback<T>) => elt(obj));
if (deleteCallbacks) {
deleteCallbacks.forEach((elt: ObjectCallback<T>) => elt(obj));
}
if (namespaceObjects.size === 0) {
objects.delete(namespace);
Expand Down

0 comments on commit 15e74b9

Please sign in to comment.