Merge pull request #368 from brendandburns/configit

Fix bugs in programmatic cluster config. Add unit test.
kubernetes-client · Nov 19, 2019 · 34cfa68 · 34cfa68
2 parents 2109605 + cf6c628
commit 34cfa68
Show file tree

Hide file tree

Showing 2 changed files with 40 additions and 0 deletions.
diff --git a/src/config.ts b/src/config.ts
@@ -53,6 +53,12 @@ export class KubeConfig {
      */
     public 'currentContext': string;
 
+    constructor() {
+        this.contexts = [];
+        this.clusters = [];
+        this.users = [];
+    }
+
     public getContexts() {
         return this.contexts;
     }
@@ -224,6 +230,9 @@ export class KubeConfig {
     }
 
     public addCluster(cluster: Cluster) {
+        if (!this.clusters) {
+            this.clusters = [];
+        }
         this.clusters.forEach((c: Cluster, ix: number) => {
             if (c.name === cluster.name) {
                 throw new Error(`Duplicate cluster: ${c.name}`);
@@ -233,6 +242,9 @@ export class KubeConfig {
     }
 
     public addUser(user: User) {
+        if (!this.users) {
+            this.users = [];
+        }
         this.users.forEach((c: User, ix: number) => {
             if (c.name === user.name) {
                 throw new Error(`Duplicate user: ${c.name}`);
@@ -242,6 +254,9 @@ export class KubeConfig {
     }
 
     public addContext(ctx: Context) {
+        if (!this.contexts) {
+            this.contexts = [];
+        }
         this.contexts.forEach((c: Context, ix: number) => {
             if (c.name === ctx.name) {
                 throw new Error(`Duplicate context: ${c.name}`);

diff --git a/src/config_test.ts b/src/config_test.ts
@@ -1123,6 +1123,31 @@ describe('KubeConfig', () => {
         });
     });
 
+    describe('Programmatic', () => {
+        it('should be able to generate a valid config from code', () => {
+            const kc = new KubeConfig();
+            kc.addCluster({
+                name: 'testCluster',
+                server: `https://localhost:9889`,
+                skipTLSVerify: true,
+            });
+            kc.addUser({
+                token: 'token',
+                username: 'username',
+                name: 'testUser',
+            });
+            kc.addContext({
+                cluster: 'testCluster',
+                name: 'test',
+                user: 'testUser',
+            });
+            kc.setCurrentContext('test');
+
+            expect(kc.getCurrentCluster()!.name).to.equal('testCluster');
+            expect(kc.getCurrentUser()!.username).to.equal('username');
+        });
+    });
+
     describe('BufferOrFile', () => {
         it('should load from root if present', () => {
             const data = 'some data for file';