-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exec type is wrong #1662
Comments
mstruebing
added a commit
to mstruebing/javascript
that referenced
this issue
Apr 27, 2024
mstruebing
added a commit
to mstruebing/javascript
that referenced
this issue
Apr 27, 2024
mstruebing
added a commit
to mstruebing/javascript
that referenced
this issue
Apr 27, 2024
mstruebing
added a commit
to mstruebing/javascript
that referenced
this issue
Apr 27, 2024
mstruebing
added a commit
to mstruebing/javascript
that referenced
this issue
Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
exec
method onExec
class returnsPromise<WebSocket>
.As the source code,
WebSocket
is imported asimport WebSocket = require('isomorphic-ws');
. Unfortunately, suchWebSocket
is the module value, not the type, the correct type should beWebSocket.WebSocket
. So the resultWebSocket
type actually fallback toglobalThis.WebSocket
(from DOM or node type definitions as user's tsconfig) , which is not compatible withws
on node env.The text was updated successfully, but these errors were encountered: