-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only sinceSeconds may be specified as a queryString for LogOptions interface #1673
Comments
We'd be happy to take a PR for this. |
@brendandburns If I simply add the option onto the LogOptions interface the request builder looks like it should take care of it, but in my testing after creating the option it is not added as a query string request or exists as an argument to a method like readNamespacedPodLog(). Am I missing something? |
Are you using this call here: https://github.com/kubernetes-client/javascript/blob/master/src/log.ts#L54 |
|
/assign |
Hey @UltraSive is this whats expected:
|
This commit adds sinceTime support to LogOptions. Fixes: kubernetes-client#1673
I think this can be closed since #1899 was merged. I'm a bit surprised that it didn't auto-close. EDIT: Maybe it didn't auto-close since the PR targeted the release-1.x branch. |
Description:
The
LogOptions
interface in theLog
class does not allow thesinceTime
parameter to be specified. According to the Kubernetes API documentation, eithersinceSeconds
orsinceTime
may be specified, but the current implementation only supportssinceSeconds
.Expected Behavior:
Users should be able to specify
sinceTime
in addition tosinceSecond
in theLogOptions
interface.Current Behavior:
Only
sinceSeconds
is supported, and attempting to usesinceTime
results in an error.Steps to Reproduce:
Try to use the
sinceTime
parameter in theLogOptions
interface.Environment:
Kubernetes Client:
@kubernetes/client-node
Node.js version:
v18.16.0
Proposed Solution:
Allow the
sinceTime
parameter to be specified in theLogOptions
interface, similar tosinceSeconds
.Where to modify:
javascript/src/log.ts
Lines 6 to 45 in b456bfc
The text was updated successfully, but these errors were encountered: