Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new object that extends KubernetesObject to generically handle all objects that have a spec property #1221

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Add a new object that extends KubernetesObject to generically handle all objects that have a spec property #1221

merged 2 commits into from
Aug 30, 2023

Conversation

bencooper222
Copy link
Contributor

@bencooper222 bencooper222 commented Aug 24, 2023 •
edited
Loading

Adding an interface for an object with a spec property which most, but not all Kubernetes objects have.

Fixes #1218

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 24, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 24, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

Welcome @bencooper222!

It looks like this is your first PR to kubernetes-client/javascript 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/javascript has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 24, 2023
@brendandburns
Copy link
Contributor

@bencooper222 thanks for the PR. While most Kubernetes resources do have a Spec field, there are a number of others (ConfigMap is probably the most obvious example) which do not.

I think we could introduce a KubernetesObjectWithSpec if that would be useful, but I don't think that we can/should change KubernetesObject in this way.

@bencooper222
Copy link
Contributor Author

Thank you for the quick response! I've revised the PR to match your suggestion.

@bencooper222 bencooper222 changed the title Add a spec to the Kubernetes Object type Add a new object that extends KubernetesObject to generically handle all objects that have a spec property Aug 26, 2023
@bencooper222 bencooper222 marked this pull request as ready for review August 26, 2023 01:00
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 26, 2023
brendandburns
brendandburns reviewed Aug 28, 2023
View reviewed changes
.npmrc Outdated
@@ -0,0 +1,2 @@
# for contributors with a corporate registry, this will make sure we use the public one
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this file as it is unrelated to this change.

@brendandburns
Copy link
Contributor

@bencooper222 looks good, but please remove the .npmrc file that accidentally got added to this PR.

@bencooper222 bencooper222 force-pushed the benc/specced-kubernetes-object branch 2 times, most recently from 773cb7b to 89b3cc3 Compare August 28, 2023 18:30
@bencooper222
Copy link
Contributor Author

@bencooper222 looks good, but please remove the .npmrc file that accidentally got added to this PR.

Fixed

@brendandburns
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bencooper222, brendandburns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2023
@k8s-ci-robot k8s-ci-robot merged commit 66d3c15 into kubernetes-client:master Aug 30, 2023
7 checks passed
@bencooper222 bencooper222 deleted the benc/specced-kubernetes-object branch August 30, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendandburns brendandburns brendandburns left review comments

@drubin drubin Awaiting requested review from drubin

Assignees

@brendandburns brendandburns

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KubernetesObject type should have a spec field
3 participants
@bencooper222 @k8s-ci-robot @brendandburns