-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an additional test for version synchronization #1268
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if that can be applied in this context (when/where the test runs) but wouldn't an npm install
with a relativlely recent npm
version and a git diff
achieve the same with a bit more variety of possible mismatches/errors?
@mstruebing I think there is a value in having this all run during I suppose we could shell out and run those commands, but that would potentially modify the user's environment (via the Open to suggestions though. Also, I'm not sure why the tests are failing... |
I think there's a separate lint failure that got introduce somehow, I will try to fix it in a different PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests are passing 🙌
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, mstruebing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.