-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not overwrite current context #1487
fix: do not overwrite current context #1487
Conversation
with a null/undefined one When having multiple configs in KUBECONFIG only one of them may have the current context set but it will be overwritten by an empty value if preserveContext is not explicitly set which is not the case when using kubectl binary
Welcome @carlossg! |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, carlossg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Any chance you can cherry-pick this onto the |
sure, #1488 |
with a null/undefined one
When having multiple configs in
KUBECONFIG
only one of them may have the current context setbut it will be overwritten by an empty value if preserveContext is not explicitly set
which is not the case when using kubectl binary