-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: custom path for service account token (supporting TokenVolume projection) #1549
feat: custom path for service account token (supporting TokenVolume projection) #1549
Conversation
Welcome @omerlh! |
While investigating the issue with CA and token projection I found this issue kubernetes/kubernetes#53315, I asked for help on Kubernetes slack |
a369b3a
to
307390e
Compare
307390e
to
c423a05
Compare
c423a05
to
de18d0e
Compare
When using TokenProjection need also to mount the custom config map |
/lgtm Thanks for the PR! Once this merges, can you cherrypick it into the |
ugh, looks like we need to fix the linter somewhat. |
Yeah, the linter error does not look related to my changes so I am not sure what to do, I think need to upgrade linter rules maybe? |
Hey @omerlh I think the linter errors are not really failing, prettier is what is failing. I'm not sure about our linter setup though, we should probably switch to eslint or something else which is supported as tslint is deprecated since quite a while (2019) |
de18d0e
to
342b796
Compare
Sure, I just did - let's see if this will help! |
/lgtm Thank you for your contribution 🎉 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, mstruebing, omerlh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fix #1528
I am not sure about the CA - I need to see if it will be there if using the projected volume 🤔