Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add examples to generic api (inside object.ts) #1754

Open
wants to merge 1 commit into
base: release-1.x
Choose a base branch
from
Open

add examples to generic api (inside object.ts) #1754

wants to merge 1 commit into from

Conversation

zfrhv
Copy link
Contributor

@zfrhv zfrhv commented Jun 24, 2024

same as #1705

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 24, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zfrhv
Once this PR has been reviewed and has the lgtm label, please assign mstruebing for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 24, 2024
mstruebing
mstruebing reviewed Jun 25, 2024
View reviewed changes
Copy link
Member

@mstruebing mstruebing left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for porting these over 🙏
Did you test these with the new code?
Not sure if we changed anything in these APIs right now on top of my head.
If not, I can test this soonish but doesn't have the time right now.

examples/kubectl/equivalents/apply.js Outdated Show resolved Hide resolved
@zfrhv
Copy link
Contributor Author

zfrhv commented Jun 25, 2024

hi, I didnt tested these examples not with the new code and not with old.
I dont have environments anymore to test.

sorry for the misunderstanding

@zfrhv
basic generic api examples
e9d43da 
Signed-off-by: zahar <zfrhv2010@gmail.com>
@zfrhv
Copy link
Contributor Author

zfrhv commented Jun 27, 2024

I updated the import

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstruebing mstruebing mstruebing left review comments

@brendandburns brendandburns Awaiting requested review from brendandburns

@davidgamero davidgamero Awaiting requested review from davidgamero

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zfrhv @k8s-ci-robot @davidgamero @mstruebing